Skip to content

automation:add new workaround for automation python3package lro#2967

Merged
stephybun merged 2 commits intohashicorp:mainfrom
wuxu92:workaround/py3lro
Aug 23, 2023
Merged

automation:add new workaround for automation python3package lro#2967
stephybun merged 2 commits intohashicorp:mainfrom
wuxu92:workaround/py3lro

Conversation

@wuxu92
Copy link
Copy Markdown
Collaborator

@wuxu92 wuxu92 commented Aug 22, 2023

add a workaround for Azure/azure-rest-api-specs#25435

Comment on lines +9 to +22
var _ workaround = workaroundAutomation25434{}

type workaroundAutomation25434 struct {
}

func (workaroundAutomation25434) IsApplicable(apiDefinition *models.AzureApiDefinition) bool {
return apiDefinition.ServiceName == "Automation" && apiDefinition.ApiVersion == "2022-08-08"
}

func (workaroundAutomation25434) Name() string {
return "Automation / 25434"
}

func (workaroundAutomation25434) Process(apiDefinition models.AzureApiDefinition) (*models.AzureApiDefinition, error) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25434?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, typo fixed.

workaroundAuthorization25080{},
workaroundDigitalTwins25120{},
workaroundAutomation25108{},
workaroundAutomation25434{},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25434?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

)

var _ workaround = workaroundAutomation25434{}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the issue here as well as a brief summary on the issue.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

Copy link
Copy Markdown
Contributor

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 🐞

@stephybun stephybun merged commit 34ba542 into hashicorp:main Aug 23, 2023
@wuxu92 wuxu92 deleted the workaround/py3lro branch August 24, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants